Nexus: Add dependency versions file + update docs #5256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add requirements_minimal. The intent is to advertise to people that the full set of requirements is not needed. e.g. if spglib breaks, or so that someone using a different package manager can see that everything is not absolutely required. If requirements_minimal is not present people will think that all the packages are required, which is not the case. |
|
|
|
Test this please |
ye-luo
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR should close #5253. A
requirements.txtfile was added inqmcpack/nexus/. I did not addrequirements_minimal.txtas only numpy is needed for core functionality and adding a file for just a single package seems redundant to me.Appropriate description has been added to the Nexus documentation. Other smaller issues were also fixed in the docs: python3 support, and
--userinstead of-user.What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Local Linux Machine
Checklist